Failing build on Ubuntu 18.0.4

Description

We're using Conan as a package manager (cassandra-driver/2.13.0/bincrafters/stable), which comes pre-built for GCC with stdlibc++. We're using Clang 9.0.0 and libc+, which requires us to build the code from source. The library doesn't compile due to warnings being treated as errors. Example below (I had to manually remove the -Werror flag, due to error: missing in the output).

src/utils.cpp:106:65: warning: 'ptr_fun<int, int>' is deprecated [-Wdeprecated-declarations]
std::find_if(str.begin(), str.end(), std::not1(std::ptr_fun<int, int>(::isspace))));

This is a good example where -Werror can be harmful. It's a great way to minimize warnings during development, but would ease the usage of the library a lot of we can remove that compiler flag through CMake. I'm more than happy to contribute if possible! It's hard to catch up with all new different compilers so this can be a very minor change resulting in a big improvement for us consumers of this library.

clang version 10.0.0 (top of tree, same error on 9.0.0)
cmake version 3.16.0-rc1
Ubuntu 18.04.3 LTS
Compiler flags: -stdlib=libc++
Linker flags: -lc++

Environment

None

Status

Assignee

Unassigned

Reporter

Fredrik Slättman

Labels

None

PM Priority

None

Reproduced in

None

External issue ID

None

External issue ID

None

External issue ID

None

External issue ID

None

External issue ID

None

External issue ID

None

Doc Impact

None

Reviewer

Michael Penick

Size

None

Priority

Major
Configure