Shade the Netty dependency

Description

Configure maven-shade-plugin to "internalize" the Netty dependency: this removes the dependency in the POM, and copies all the classes into driver-core with a renamed package.

This avoids dependency hell for people who use a different Netty version in their app.

We can't do that for Metrics and Guava because they are exposed in the driver's public API.

Environment

None

Pull Requests

None

Activity

Show:
Alex Popescu
November 10, 2014, 8:24 PM

I assume we'll have to do this for 2.1.x too?

Olivier Michallat
November 11, 2014, 8:37 AM

Yes, it will get merged to the 2.1 branch.

Olivier Michallat
November 20, 2014, 11:06 AM

: not much to test on this one, it will be covered implicitly by duration tests (which I've tried locally already).

Pierre Laporte
December 12, 2014, 1:49 PM

Verified after Following 's tests :

  • pom.xml still mentions netty as a dependency but (see next point)

  • mvn dependency:tree in client project does not show netty as a dependency anymore

  • javap -c in classes like Connection of the packaged jar only show references to com.datastax.shaded.netty classes

Fixed

Assignee

Pierre Laporte

Reporter

Olivier Michallat

Labels

None

PM Priority

None

Affects versions

None

Fix versions

Pull Request

None

Doc Impact

None

Size

None

External issue ID

None

External issue ID

None

Priority

Minor
Configure