Netty buffer leak when frame compression is enabled

Description

When frame compression is enabled, the FrameCompressor#decompress makes a copy of the original frame before it gets passed to Message.ProtocolDecoder.

Therefore the body of the original frame is never released, which causes a leak. This is easily reproduced by running a test with compression enabled and the flag -Dio.netty.leakDetectionLevel=PARANOID.

Environment

None

Pull Requests

None

Activity

Show:
Olivier Michallat
April 30, 2015, 1:40 PM

And this also happened for compression btw.

Andy Tolbert
May 1, 2015, 7:06 PM

Executed a sustained 12/hr test with LZ4 compression with io.netty.leakDetectionLevel=advanced. Did not observe any leak messages like the ones present prior to this change. Looks good to me!

Fixed

Assignee

Olivier Michallat

Reporter

Olivier Michallat

Labels

None

PM Priority

None

Reproduced in

None

Affects versions

None

Fix versions

Pull Request

None

Doc Impact

None

Size

None

External issue ID

None

External issue ID

None

Priority

Blocker
Configure