logger.trace statements in hot code path in CodecRegistry should use isTraceEnabled

Description

There are a number of logger.trace statements in CodecRegistry that should be updated to log conditionally based on whether or not trace is enabled, i.e.:

should be:

Environment

None

Pull Requests

None

Activity

Show:
Olivier Michallat
August 26, 2015, 8:49 AM

I think it's fine, the javadoc for trace states:

This form avoids superfluous object creation when the logger is disabled for the TRACE level.

Andy Tolbert
August 26, 2015, 4:24 PM

Yeah, that makes sense. Given that and that there isn't any dynamic string construction otherwise, I think we don't need this change. Closing.

Not a Problem

Assignee

Unassigned

Reporter

Andy Tolbert

Labels

None

PM Priority

None

Affects versions

Fix versions

None

Pull Request

None

Doc Impact

None

Size

None

External issue ID

None

External issue ID

None

Priority

Minor
Configure