IPv6 InetAddressType support for Windows
Description
Because Python does not implement inet_pton and inet_ntop on Windows until 3.4, IPv6 InetAddressType values are not currently supported on Windows.
Environment
None
Pull Requests
None
Activity
Show:
Adam Holmberg
May 27, 2015, 9:26 PM
Same as fix for PYTHON-309:
https://github.com/datastax/python-driver/pull/337
Adam Holmberg
May 28, 2015, 7:10 PM
for test coverage review:
Unit tests covering protocol changes.
Unit tests covering cqltypes changes.
Basic integration test cqltype serdes test for inet type
Protocol read_inet covered in integration by any test that causes cluster node status changes.
Michael Penick
May 31, 2015, 7:42 PM
+1
Greg Bestland
June 1, 2015, 7:37 PM
I reviewed the tests they look sufficient to cover the alternate socket implementation for windows and python <3.4.Unix implementation is virtually unchanged. This looks good to me.
Fixed
Assignee
Greg Bestland
Reporter
Tyler Hobbs
Fix versions
Labels
None
Reproduced in
None
PM Priority
None
External issue ID
None
Doc Impact
None
Reviewer
None
Size
None
Pull Request
None
Affects versions
Priority
Configure