timestamp is not a cql reserved keyword

Description

In cqlsh, timestamp is escaped with double quotes as for reserved keywords when according to the cql documentation it is not a reserved keyword.

clqsh relies on metadata.maybe_escape_name() to decide whether to escape keywords.

To reproduce the problem, in cqlsh create the following table:

This will lead to the following completion when building an insert statement:

You may want to review other keywords as well.

Please see CASSANDRA-9232 for more details.

Environment

None

Pull Requests

None

Activity

Show:
Adam Holmberg
May 27, 2015, 9:51 PM

Maybe this

Stefania Alborghetti
May 28, 2015, 12:12 PM
Edited

Yes, I had found this and they look the same.

I think we should also always pick up the latest cql version.

Adam Holmberg
May 28, 2015, 4:09 PM
Michael Penick
May 31, 2015, 7:53 PM

Missing a couple unreserved keywords? Otherwise, +1.

Greg Bestland
June 1, 2015, 7:22 PM

Based on changes only unit tests were needed. +1 LGTM.

Fixed

Assignee

Greg Bestland

Reporter

Stefania Alborghetti

Fix versions

Labels

None

Reproduced in

None

PM Priority

B

External issue ID

None

Doc Impact

None

Reviewer

None

Size

None

Pull Request

None

Priority

Minor
Configure