Avoid calling synchronized Cluster.Manager.init()

Description

When we did some performance profiling on our application we found some impact from calling the synchronized method Cluster.Manager.init(), not a huge impact but I think it could easily be avoided.

The first thing that is done inside the init() method is checking if it has already been initialized and just returns if that is the case. If this check was done before calling init() we avoid calling a synchronized method when we don't need to. I have prepared a patch for this.

Environment

None

Pull Requests

None

Activity

Show:

Olivier Michallat 
June 27, 2016 at 6:44 PM

See discussion on the PR.

Won't Fix

Details

Assignee

Reporter

Affects versions

Sprint

Priority

Created September 3, 2015 at 11:52 AM
Updated August 17, 2020 at 7:36 AM
Resolved June 27, 2016 at 6:44 PM